Tweak URL paths for new/create and refine handling of return visitors #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pezholio
approved these changes
Oct 7, 2019
This removes the need for including the :slug parameter from the URL and also makes the URL read a bit better by using the word "claim" instead of "new" (which also matches the URL structure that Mark came up with when doing the work on domains and service naming)
Although the outcome at the moment is the same, using the `ClaimUpdate` when creating a new claim couples the code in a way that could cause issues. Instead, making this closer to a generic `create` action.
We shouldn't need to pass the slug around in the routing as we can already determine the first slug in the sequence. Also Changes the path from `/student-loans?slug=qts-year` to `/student-loans/claim`.
Where possible we use the page_sequence object to determine the current slug for better encapsulation.
At the moment visiting the path for claims#new will throw a routing exception if a claim is already in progress. To deal with this we redirect these users to the first page in the sequence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a couple of things.
Firstly it reworks the URLS to be a bit friendlier to the user:
#newbecomes/student-loans/claiminstead of/student-loans/new?slug=qts-year#createbecomes/student-loans/claiminstead of/student-loans?slug=qts-yearSecondly it adds some code to handle the scenario where a user visits
#newwith an already in-progress claim. This was resulting in exceptions being raised.