Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back art for tracks in Stonesense #167

Merged
merged 3 commits into from
Jan 25, 2025
Merged

Add back art for tracks in Stonesense #167

merged 3 commits into from
Jan 25, 2025

Conversation

realSquidCoder
Copy link
Collaborator

Cleaned up the outdated XMLs and tested the preexisting art.

@realSquidCoder
Add back art for tracks in Stonesense
5646ffe 
Cleaned up the outdated XMLs and tested the preexisting art.
@realSquidCoder realSquidCoder marked this pull request as ready for review January 25, 2025 05:40
@realSquidCoder
Copy link
Collaborator Author

realSquidCoder commented Jan 25, 2025 •
edited
Loading

Someone should probably do more rigorous testing on this one, but it looked good to me

myk002
myk002 reviewed Jan 25, 2025
View reviewed changes
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know why these were commented out in the first place?

also, needs changelog entry

@realSquidCoder
Copy link
Collaborator Author

Honestly, no, i don't know. There's a lot of stuff in here that's commented out which, IMO makes Stonesense look better. (Like the alt water gfx)

@realSquidCoder
Copy link
Collaborator Author

Maybe it was because back whenever it was added, not everyone had the gfx card to handle it, but idk for sure

myk002
myk002 reviewed Jan 25, 2025
View reviewed changes
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usual format is var="value" not var = "value". I suggest you stay consistent with established standards

@myk002 myk002 merged commit 3fb137a into DFHack:master Jan 25, 2025
4 checks passed
@realSquidCoder realSquidCoder deleted the squid-ssense-trackart branch January 25, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myk002 myk002 myk002 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
51.05-r2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@realSquidCoder @myk002