-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expressions highlighter #111
Merged
RedVortexDev
merged 13 commits into
DFOnline:main
from
sylviameows:feat/highlight-expressions
Oct 27, 2024
Merged
expressions highlighter #111
RedVortexDev
merged 13 commits into
DFOnline:main
from
sylviameows:feat/highlight-expressions
Oct 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeRNG
requested changes
Oct 14, 2024
src/main/java/dev/dfonline/codeclient/dev/highlighter/ExpressionHighlighter.java
Outdated
Show resolved
Hide resolved
I tried to fix this, but escaping decoration tags is not as straightforward as one might assume, if anyone else would like to take a crack at figuring it out, i kept my attempt inside the code but commented out. (this also isnt detrimental to user experience imo) This bug has been fixed. |
GeorgeRNG
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements a feature previously provided by recode (the "expression highlighter").
what it does:
edits minecraft's chat box field to provide syntax highlighting for minimessage and DF expressions in commands like
/plot name
,/txt
, and/lore
as well as when editing variable items like strings, styled text, numbers, and variables.examples:
also includes a config which allows you to customize how the expression highlighter appears:
there may be some strange quirks with it though that may need more ironing out, but in its current state it is definitely passable