Preview Item Tags #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeRNG
approved these changes
Sep 25, 2024
| @@ -111,6 +118,33 @@ public void onInitializeClient() { | |||
| Commands.register(dispatcher); | |||
| }); | |||
|
|
|||
| ItemTooltipCallback.EVENT.register((stack, context, lines) -> { | |||
There was a problem hiding this comment.
not sure if I want to keep CodeClient consistently not using fabric APIs, or turn cc into a weird mix of fabric apis and mixins for which fabric can't provide for.
We probably should move towards the second one for "correctness" and compatibility sake
There was a problem hiding this comment.
I didn't know we were doing that lol, fabric api is a standard and a dependency of all mods, it would be more unconventional to use YACL than fapi, we should be using the api as it allows us to register into events without thinking much while not accidentally interfering with other mods. "mix of fabric api and mixins" is basically what every mod is like
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a keybind that shows item tags made in DiamondFire when held, strings in aqua, numbrs in red, other in DiamondFire's Any Value color.