Introduce properties like res1d_catchment, res1d_node, etc. #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-kipawa
approved these changes
Dec 10, 2024
gedaskir
force-pushed
the
minor/res1d_location_properties
branch
from
f10762e to
75738a7
Compare
ryan-kipawa
approved these changes
Dec 11, 2024
added 5 commits
December 13, 2024 06:27
…sponding result_location.
…as an API hidden parameter
gedaskir
force-pushed
the
minor/res1d_location_properties
branch
from
75738a7 to
10afaef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the end I chose to go for convention of res1d_catchment instead of m1d_catchment.