Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v1 0 1 #157

Merged
merged 3 commits into from
Jan 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@

### Changed

## [1.0.1] - 2025-01-13

### Fixed
- Res1D can now be saved when it was loaded using filters

## [1.0.0] - 2024-12-19

### Changed
Expand Down
2 changes: 1 addition & 1 deletion mikeio1d/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
# Dev branch marker is: 'X.Y.dev' or 'X.Y.devN' where N is an integer.
# 'X.Y.dev0' is the canonical version of 'X.Y.dev'
#
__version__ = "1.0.0"
__version__ = "1.0.1"

if "64" not in platform.architecture()[0]:
raise Exception("This library has not been tested for a 32 bit system.")
Expand Down
1 change: 0 additions & 1 deletion mikeio1d/result_network/result_location.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ def _repr_html_(self) -> str:
@property
def res1d(self) -> Res1D:
"""The Res1D instance that this location belongs to."""
# TODO: Consider to remove this property for version 1.0.0
return self._creator.res1d

@property
Expand Down
1 change: 0 additions & 1 deletion mikeio1d/result_network/result_locations.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ def _repr_html_(self) -> str:
@property
def res1d(self) -> Res1D:
"""The Res1D instance that these locations belong to."""
# TODO: Consider to remove this property for version 1.0.0
return self._creator.res1d

@property
Expand Down
9 changes: 0 additions & 9 deletions mikeio1d/result_network/result_structure.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,15 +74,6 @@ def res1d_reach(self) -> IRes1DReach:
"""DHI.Mike1D.ResultDataAccess.IRes1DReach corresponding to this result structure."""
return self._creator.reach

@property
def structure_id(self):
"""Get structure ID."""
# TODO: Remove this in 1.0.0
warn(
"Please use .id instead of .structure_id. This attribute will be removed in the future."
)
return self.id

@property
def id(self) -> str:
"""Structure ID."""
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ exclude = ["notebooks", "tests", "images"]

[project]
name = "mikeio1d"
version = "1.0.0"
version = "1.0.1"
description = "A package that uses the DHI MIKE1D .NET libraries to read res1d and xns11 files."
readme = "README.md"
requires-python = ">=3.9"
Expand Down
7 changes: 0 additions & 7 deletions tests/test_res1d_network.py
Original file line number Diff line number Diff line change
Expand Up @@ -442,10 +442,3 @@ def test_structure_reach_static_attributes(res1d_network):
assert structures.s_115p1.type == "Pump"
assert structures.s_115p1.id == "115p1"
assert structures.s_115p1.chainage == pytest.approx(41.21402714094492)


def test_structure_reach_maintains_backweards_compatibility(res1d_network):
structures = res1d_network.structures

with pytest.warns(UserWarning):
assert structures.s_119w1.structure_id == structures.s_119w1.id
Loading