Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-1556: Updated Readme for frontend formatting #1557

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

AdarshSamani
Copy link
Contributor

@AdarshSamani AdarshSamani commented Feb 15, 2025

Pull Requests Requirements

  • The PR title includes a brief description of the work done, including the
    Issue number if applicable.
  • The PR includes a video showing the changes for the work done.
  • The PR title follows conventional commit label standards.
  • The changes confirm to the OpenElis Global x3 Styleguide and design
    documentation.
  • The changes include tests or are validated by existing tests.
  • I have read and agree to the Contributing Guidelines of this project.

Summary

The previous steps for formatting frontend in readme gave error prettier not found

Screenshots

Before:
image (1)

After:
image
image

Related Issue

#1556

@AdarshSamani
Copy link
Contributor Author

@mozzy11 let me know you review
Thank you

@josephbate
Copy link
Contributor

nice work!

Copy link
Contributor

@Bahati308 Bahati308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this @AdarshSamani , though personally I have never faced any issues with the current order of formatting. However for this case, have you considered the npm ci,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants