-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Show required field text and red outline after user attempt #1579
base: develop
Are you sure you want to change the base?
Conversation
@@ -552,7 +553,7 @@ const Index = () => { | |||
} | |||
}; | |||
const elementError = (path) => { | |||
if (errors?.errors?.length > 0) { | |||
if (submitted && errors?.errors?.length > 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The errors should show after a field is changed not after submiting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@OsauravO cypress CI test is failing can you check once locally! and update changes to fix it!
also, can you check if this form need any changes! { see below } while creating new patient |
@adityadeshlahre will do it in another PR |
Pull Requests Requirements
Issue number if applicable.
documentation.
Summary
Screenshots
Before
After
Screencast.from.2025-02-20.15-45-38.mp4
Related Issue
#839
Other
[Add any additional information or notes here]