Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show required field text and red outline after user attempt #1579

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

OsauravO
Copy link
Contributor

@OsauravO OsauravO commented Feb 19, 2025

Pull Requests Requirements

  • The PR title includes a brief description of the work done, including the
    Issue number if applicable.
  • The PR includes a video showing the changes for the work done.
  • The PR title follows conventional commit label standards.
  • The changes confirm to the OpenElis Global x3 Styleguide and design
    documentation.
  • The changes include tests or are validated by existing tests.
  • I have read and agree to the Contributing Guidelines of this project.

Summary

Screenshots

Before

Before

After

Screencast.from.2025-02-20.15-45-38.mp4

Related Issue

#839

Other

[Add any additional information or notes here]

@@ -552,7 +553,7 @@ const Index = () => {
}
};
const elementError = (path) => {
if (errors?.errors?.length > 0) {
if (submitted && errors?.errors?.length > 0) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The errors should show after a field is changed not after submiting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@adityadeshlahre
Copy link
Contributor

adityadeshlahre commented Feb 21, 2025

@OsauravO cypress CI test is failing can you check once locally! and update changes to fix it!

npm i && npm run cy:run

also, can you check if this form need any changes! { see below } while creating new patient

image

@OsauravO
Copy link
Contributor Author

@adityadeshlahre will do it in another PR

@OsauravO OsauravO requested a review from mozzy11 February 25, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants