Changed components to use Carbon grid instead of inlineDiv #1614
+251
−245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vaishnavi Bhandari <[email protected]>
Signed-off-by: Vaishnavi Bhandari <[email protected]>
Signed-off-by: Vaishnavi Bhandari <[email protected]>
Signed-off-by: Vaishnavi Bhandari <[email protected]>
Signed-off-by: Vaishnavi Bhandari <[email protected]>
Signed-off-by: Vaishnavi Bhandari <[email protected]>
Signed-off-by: Vaishnavi Bhandari <[email protected]>
Signed-off-by: Vaishnavi Bhandari <[email protected]>
Signed-off-by: Vaishnavi Bhandari <[email protected]>
mozzy11
reviewed
Feb 27, 2025
| onChange={(date) => handleCollectionDate(date)} | ||
| value={sampleXml.collectionDate} | ||
| labelText={intl.formatMessage({ id: "sample.collection.date" })} | ||
| className="inputText" |
There was a problem hiding this comment.
can you get rid of this class , and we purly rely on carbon grid for the layout?
There was a problem hiding this comment.
I will change it surely.
mozzy11
reviewed
Feb 27, 2025
| } | ||
| onChange={(time) => handleCollectionTime(time)} | ||
| value={sampleXml.collectionTime} | ||
| className="inputText" |
There was a problem hiding this comment.
get rid of the css class here
|
Thanks @peach280 . |
Signed-off-by: Vaishnavi Bhandari <[email protected]>
|
|
Signed-off-by: Vaishnavi Bhandari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Requests Requirements
Issue number if applicable.
documentation.
Summary
Fixes #978
Almost all components have been changes to use carbon grid instead of inlineDiv
Screenshots
The display is same as before but more responsive.