Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TTL generator exe path when building for windows #452

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

SpotlightKid
Copy link
Contributor

Fixes failing build when using using make to build for windows, due to path to utils/lv2_ttl_generator.exe being relative, but the generate-ttl.sh script changes working directory.

make -C dpf/utils/lv2-ttl-generator WINDOWS=true
make[1]: Entering directory '/home/chris/work/ykchorus/dpf/utils/lv2-ttl-generator'
i686-w64-mingw32-gcc lv2_ttl_generator.c -Wall -Wextra -pipe -MD -MP -fno-gnu-unique -posix -D__STDC_FORMAT_MACROS=1 -D__USE_MINGW_ANSI_STDIO=1 -mstackrealign -DNDEBUG -O3 -ffast-math -fdata-sections -ffunction-sections -mtune=generic -msse -msse2 -mfpmath=sse -fvisibility=hidden -std=gnu99 -DPTW32_STATIC_LIB -Werror -o ../lv2_ttl_generator.exe -fdata-sections -ffunction-sections -Wl,-O1,--as-needed,--gc-sections -Wl,--strip-all -static -Wl,--no-undefined -static -static-libgcc -static-libstdc++ -static
touch ../lv2_ttl_generator
make[1]: Leaving directory '/home/chris/work/ykchorus/dpf/utils/lv2-ttl-generator'
dpf/utils/generate-ttl.sh: line 38: dpf/utils/lv2_ttl_generator.exe: No such file or directory
make: *** [Makefile:125: gen] Error 127

I think this bug was introduced in 648452a, because only the code path for macOS and Posix was adapted to the changes.

@falkTX falkTX merged commit fac3172 into DISTRHO:develop Apr 30, 2024
47 checks passed
@falkTX
Copy link
Contributor

falkTX commented Apr 30, 2024

Makes sense, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants