Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move audio device settings to modem settings area. #520

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Move audio device settings to modem settings area. #520

merged 1 commit into from
Nov 1, 2023

Conversation

ptsmonteiro
Copy link
Collaborator

This moves the audio device settings from the main screen to the modem settings tab.

DJ2LS
DJ2LS approved these changes Nov 1, 2023
View reviewed changes
Copy link
Owner

@DJ2LS DJ2LS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would count this as a thing we should keep in mind and only park it in settings. Maybe we find a way how to make this easier to configure/validate on startup

@ptsmonteiro ptsmonteiro merged commit ae03bb6 into develop Nov 1, 2023
@ptsmonteiro ptsmonteiro deleted the move-audio-dev-settings-to-modem-settings branch November 1, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJ2LS DJ2LS DJ2LS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptsmonteiro @DJ2LS