Changed syntax to ES6 class structure #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't work. Found a syntax error at line 1. Would anything need to be changed in the .xml file as well ? |
|
What does it report? |
|
|
|
Did you use Mixxx 2.4 or 2.3? |
|
Ah, yes. Still using 2.3.6. My bad... Let me change that. |
|
All seems good with the latest 2.4 beta. |
|
Test it carefully, before merging... |
Pull Request Test Coverage Report for Build 7351058350
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DJPhatso In this PR I converted your code in the new ES6 class syntax, which we use for Mixxx 2.4.
Please test the modified Hercules-DJControl-MIX-scripts.js file with your controller. If everything works as before, Merge this into your branch by pressing the green button below.