Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsonschema is not listed as a dependency #276

Closed
braingram opened this issue Jul 7, 2023 · 0 comments · Fixed by #274
Closed

jsonschema is not listed as a dependency #276

braingram opened this issue Jul 7, 2023 · 0 comments · Fixed by #274

Comments

@braingram
Copy link
Contributor

Description

jsonschema is imported in dataset.py

dkist/dkist/dataset/dataset.py

Line 6 in d082995

from jsonschema.exceptions import ValidationError

but it not listed as a dependency in setup.cfg

dkist/setup.cfg

Lines 23 to 36 in d082995

install_requires =
appdirs>=1.4
asdf>=2.9.1
asdf-astropy
asdf-transform-schemas
astropy>=5
dask[array]>=2
globus-sdk>=3.0
gwcs>=0.18.0
matplotlib>=3.4
ndcube[plotting,reproject]>=2.0
numpy>=1.21
parfive[ftp]>=1.3
sunpy[net,asdf]>=4

This is and was previously provided via the dependency on asdf (which is currently evaluating options for dealing with breaking changes in jsonschema 4.18 including dropping jsonschema as a dependency).

One option would be to add jsonschema as a dependency. A second option would be to increase the lower asdf pin to 2.15 and import 'ValidationError' from asdf.exceptions.
@Cadair Cadair mentioned this issue Jul 27, 2023
Merged
SolarDrew added a commit to SolarDrew/dkist that referenced this issue Jul 31, 2023
@SolarDrew
Add jsonschema as explicit dependency
738f634 
Fixes DKISTDC#276
Cadair added a commit that referenced this issue Aug 1, 2023
@SolarDrew @Cadair @pre-commit-ci
Move dataset loading methods out into a single-dispatch function (#274)
1cdd106 
* Move dataset loading methods out into a single-dispatch function

It's a bit messy at the moment, will want some tidying up

* Update more loading commands that I somehow missed

* Forgot to commit the actual loader because I'm a fool

* Changelog

* Found another old call hiding in the docs

* Swap one no-op for another to appease the coverage gods

* Code is now constructed so that this will never run

* Add basic test for loading TiledDataset

* Use a test file that actually exists. Maybe that will help

* Update dkist/dataset/loader.py

Co-authored-by: Stuart Mumford <[email protected]>

* Update dkist/dataset/loader.py

Co-authored-by: Stuart Mumford <[email protected]>

* Revive Dataset.from_ loading methods and deprecate

Plus tests

* Raise error for unrecognised types in single-dispatch

* Pass load_dataset up to dkist

* Update changelog/274.feature.rst

Co-authored-by: Stuart Mumford <[email protected]>

* Use load_dataset in aia generation script

* Update docs to use load_dataset

* Add note for later work

* Add jsonschema as explicit dependency

Fixes #276

* asdf needs jsconschema <4 apparently

* Missed a from_asdf

* Helps if you use variables that exist

* Use pytest.warns in tests instead of pytest.raises

Because it wasn't marking code as run

* Add test to cover invalid input to loader

* Replace AstropyDeprecationWarning with new DKISTDeprecationWarning

* Imports are hard

* Forgot to add some important things

* Apply suggestions from code review

* Update dkist/dataset/loader.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: Stuart Mumford <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move dataset loading methods out into a single-dispatch function SolarDrew/dkist
1 participant
@braingram