Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: asdf converters for WCS models #156

Merged
merged 8 commits into from
Feb 16, 2022
Merged

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Feb 11, 2022

TODO:

  • Schemas
  • Test coverage?

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #156 (80df333) into main (0f9109a) will increase coverage by 0.07%.
The diff coverage is 97.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   95.37%   95.45%   +0.07%     
==========================================
  Files          26       27       +1     
  Lines        1125     1165      +40     
==========================================
+ Hits         1073     1112      +39     
- Misses         52       53       +1     
Impacted Files Coverage Δ
dkist/io/asdf/converters/models.py 97.36% <97.36%> (ø)
dkist/io/asdf/converters/__init__.py 100.00% <100.00%> (ø)
dkist/io/asdf/entry_points.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f9109a...80df333. Read the comment docs.

@Cadair Cadair marked this pull request as ready for review February 16, 2022 12:52
@Cadair Cadair added bug No Changelog Entry Needed This pull request does not need a changelog entry and removed bug labels Feb 16, 2022
@Cadair Cadair merged commit 3f8210d into DKISTDC:main Feb 16, 2022
@Cadair Cadair deleted the wcs_asdf_converters branch February 16, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Changelog Entry Needed This pull request does not need a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant