Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial pass at a two layer refactor of FileManager #176

Merged
merged 7 commits into from
Jun 20, 2022

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Jun 17, 2022

This is an attempt to tidy up the API of FileManager in a way that makes it easy to apply many slices to the same underlying file manager object.

Fixes #166

@Cadair
Copy link
Member Author

Cadair commented Jun 17, 2022

pre-commit.ci autofix

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #176 (efd147f) into main (963b2b1) will increase coverage by 0.08%.
The diff coverage is 98.47%.

@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
+ Coverage   96.27%   96.35%   +0.08%     
==========================================
  Files          28       28              
  Lines        1451     1483      +32     
==========================================
+ Hits         1397     1429      +32     
  Misses         54       54              
Impacted Files Coverage Δ
dkist/io/file_manager.py 96.38% <98.38%> (+0.86%) ⬆️
dkist/io/asdf/converters/dataset.py 89.65% <100.00%> (ø)
dkist/io/asdf/converters/file_manager.py 96.00% <100.00%> (ø)
dkist/wcs/models.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 963b2b1...efd147f. Read the comment docs.

@Cadair Cadair marked this pull request as ready for review June 20, 2022 14:25
@Cadair Cadair changed the title [WIP] Initial pass at a two layer refactor of FileManager Initial pass at a two layer refactor of FileManager Jun 20, 2022
@Cadair Cadair merged commit f80360d into DKISTDC:main Jun 20, 2022
@Cadair Cadair deleted the file_manager_refactor branch June 20, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileManager.files does not reflect the slice correctly
1 participant