Fix slicing of FileManager #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadair
commented
Aug 12, 2022
|
@eigenbrot is this diff sufficient for you? |
|
Yep, thanks! |
Codecov Report
@@ Coverage Diff @@
## main #199 +/- ##
==========================================
+ Coverage 96.27% 96.41% +0.13%
==========================================
Files 29 29
Lines 1504 1506 +2
==========================================
+ Hits 1448 1452 +4
+ Misses 56 54 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
This needs a regression test, so it's a monday job. |
Also make movie and quality report optional when downloading from dataset inventory
Cadair
force-pushed
the
fix_filemanager_ordering
branch
from
4781654 to
2dc4d47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make movie and quality report optional when downloading from dataset inventory