Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy net.attrs namespace #201

Merged
merged 7 commits into from
Sep 26, 2022
Merged

Tidy net.attrs namespace #201

merged 7 commits into from
Sep 26, 2022

Conversation

SolarDrew
Copy link
Contributor

Adds a layer of indirection to import just the names we want available into the dkist.net.attrs/a.dkist namespace. This is the same approach used by sunpy.

@SolarDrew
Copy link
Contributor Author

SolarDrew commented Aug 23, 2022

Closes #188

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #201 (d47a23c) into main (6762811) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #201   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files          29       29           
  Lines        1506     1506           
=======================================
  Hits         1452     1452           
  Misses         54       54           
Impacted Files Coverage Δ
dkist/net/attrs.py 98.75% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Cadair Cadair linked an issue Aug 23, 2022 that may be closed by this pull request
@Cadair
Copy link
Member

Cadair commented Sep 12, 2022

pre-commit.ci autofix

@Cadair Cadair merged commit 49423ac into DKISTDC:main Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean out a.dkist namespace of non-attrs
2 participants