-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to set chunksize when making the dask array #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #232 +/- ##
==========================================
+ Coverage 97.18% 97.20% +0.01%
==========================================
Files 37 37
Lines 2095 2108 +13
==========================================
+ Hits 2036 2049 +13
Misses 59 59
|
b879eab
to
8c24c44
Compare
SolarDrew
reviewed
May 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
SolarDrew
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR got a little 🐂 shaving, I removed the use of
ExternalArrayReference
, however, its primary purpose is to provide the primatives to allow the optional specification of a chunksize when making a dask array from each loader referenced by an asdf.This should be all the changes needed to test the performance of loading a chunked array, and then changes to the asdf maker can use them later.
This also cleans up the implementation of the Loader class by making the abstract method the
__getitem__
method, this is needed to access.section
and read only a subset of the file.TODO: