Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download methods to FileManager for quality and movie #235

Merged
merged 3 commits into from
Apr 27, 2023

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Apr 27, 2023

Fixes #169

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #235 (66be4d0) into main (17721d3) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
+ Coverage   97.16%   97.18%   +0.02%     
==========================================
  Files          37       37              
  Lines        2078     2095      +17     
==========================================
+ Hits         2019     2036      +17     
  Misses         59       59              
Impacted Files Coverage Δ
dkist/dataset/dataset.py 92.30% <ø> (ø)
dkist/io/file_manager.py 97.32% <100.00%> (+0.26%) ⬆️

@SolarDrew
Copy link
Contributor

LGTM pending tests 👍

@Cadair Cadair merged commit a9990ee into DKISTDC:main Apr 27, 2023
@Cadair Cadair deleted the qualtiy_report_preview_movie branch April 27, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose ability to download the Quality Report PDF and Browse Movie
2 participants