VaryingCelestialTransform fix and unit tests #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsform(). Rewrote cvt unit tests and ensured both imager and slit classes have 1D - 3D LUT table support and full round-trip tests for the entire pixel table. Minor cleanup and reformatting.
Codecov Report
@@ Coverage Diff @@
## main #285 +/- ##
==========================================
+ Coverage 96.75% 97.51% +0.76%
==========================================
Files 40 40
Lines 2400 2412 +12
==========================================
+ Hits 2322 2352 +30
+ Misses 78 60 -18
|
Cadair
reviewed
Aug 4, 2023
Co-authored-by: Stuart Mumford <[email protected]>
Added shape error tests for 3D vcts.
Renamed some variables o be more meaningful.
Cadair
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed coordinate reversal in VaryingCelestialTransformSlit2D._map_transform().
Rewrote vct unit tests and ensured both imager and slit classes have 1D - 3D LUT table support and full round-trip tests for the entire pixel table.
Minor cleanup and reformatting.
It is acknowledged that massive code duplication exists in the vct classes and unit tests. However, this is temporary, as the refactor of the vct classes, which I am embarking on soon, will remediate this problem. a shared test fixture could reduce the code duplication in the unit tests, it is not worth the effort to implement at this point.