Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An assortment of small fixes #286

Merged
merged 6 commits into from
Aug 7, 2023
Merged

An assortment of small fixes #286

merged 6 commits into from
Aug 7, 2023

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Aug 7, 2023 •
edited
Loading

Fixes #252

@codecov
Copy link

codecov bot commented Aug 7, 2023 •
edited
Loading

Codecov Report

Merging #286 (200b3d0) into main (df0724f) will increase coverage by 1.03%.
The diff coverage is 100.00%.

❗ Current head 200b3d0 differs from pull request most recent head b675a32. Consider uploading reports for the commit b675a32 to get more accurate results

@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
+ Coverage   97.51%   98.55%   +1.03%     
==========================================
  Files          40       40              
  Lines        2412     2414       +2     
==========================================
+ Hits         2352     2379      +27     
+ Misses         60       35      -25
Files Changed Coverage Δ
dkist/utils/sysinfo.py 97.05% <100.00%> (+78.30%) ⬆️

@Cadair Cadair added the No Changelog Entry Needed This pull request does not need a changelog entry label Aug 7, 2023
@Cadair Cadair marked this pull request as ready for review August 7, 2023 12:47
@Cadair Cadair requested a review from SolarDrew August 7, 2023 12:47
SolarDrew
SolarDrew approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@SolarDrew SolarDrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Cadair Cadair enabled auto-merge (squash) August 7, 2023 13:06
@Cadair Cadair merged commit 344ad8e into DKISTDC:main Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SolarDrew SolarDrew SolarDrew approved these changes

Assignees
No one assigned
Labels
No Changelog Entry Needed This pull request does not need a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Output of dkist.system_info() needs updating
2 participants
@Cadair @SolarDrew