Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_dataset improvements #287

Merged
merged 6 commits into from
Aug 8, 2023
Merged

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Aug 8, 2023

No description provided.

@Cadair Cadair requested a review from SolarDrew August 8, 2023 12:27
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #287 (1badca9) into main (344ad8e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
+ Coverage   98.55%   98.56%   +0.01%     
==========================================
  Files          40       40              
  Lines        2414     2443      +29     
==========================================
+ Hits         2379     2408      +29     
  Misses         35       35              
Files Changed Coverage Δ
dkist/dataset/dataset.py 95.50% <100.00%> (+0.05%) ⬆️
dkist/dataset/loader.py 100.00% <100.00%> (ø)

@Cadair
Copy link
Member Author

Cadair commented Aug 8, 2023

Somewhat prophetically, the new online build is failing because of a server issue at the DC. Otherwise I think this is good to go.

Copy link
Contributor

@SolarDrew SolarDrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 10/10, no notes.

@SolarDrew SolarDrew merged commit 185c249 into DKISTDC:main Aug 8, 2023
@Cadair Cadair deleted the load_dataset_improvements branch August 8, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants