Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin down gwcs until ASDF files are updated #301

Merged
merged 6 commits into from
Oct 6, 2023
Merged

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Oct 6, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c7e6115) 98.28% compared to head (c6b9cf9) 98.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
- Coverage   98.28%   98.28%   -0.01%     
==========================================
  Files          40       40              
  Lines        2453     2451       -2     
==========================================
- Hits         2411     2409       -2     
  Misses         42       42              
Files Coverage Δ
dkist/io/loaders.py 95.91% <100.00%> (-0.17%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cadair Cadair requested a review from SolarDrew October 6, 2023 10:47
Copy link
Contributor

@SolarDrew SolarDrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Cadair Cadair merged commit 00a1943 into DKISTDC:main Oct 6, 2023
@Cadair Cadair deleted the gwcs branch October 6, 2023 10:51
Cadair added a commit to Cadair/dkist that referenced this pull request Oct 16, 2023
* pin down gwcs until ASDF files are updated

* Add changelog

* Fix a nested Dask array bug

* Skip some cells to see if the build passes

* Fix doctest

* this is silly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants