DKISTDC · Cadair · Mar 25, 2024 · Mar 7, 2024 · Mar 7, 2024 · Mar 7, 2024
diff --git a/changelog/344.trivial.rst b/changelog/344.trivial.rst
@@ -0,0 +1 @@
+Refactor various subclasses of VaryingCelestialTransform to centralise the calculations in preparation for improving performance.
diff --git a/dkist/io/asdf/converters/models.py b/dkist/io/asdf/converters/models.py
@@ -23,25 +23,9 @@ class VaryingCelestialConverter(TransformConverterBase):
     ]
 
     def select_tag(self, obj, tags, ctx):
-        from dkist.wcs.models import (InverseVaryingCelestialTransform,
-                                      InverseVaryingCelestialTransform2D,
-                                      InverseVaryingCelestialTransform3D,
-                                      VaryingCelestialTransform, VaryingCelestialTransform2D,
-                                      VaryingCelestialTransform3D)
-
-        if isinstance(
-                obj,
-                (VaryingCelestialTransform,
-                 VaryingCelestialTransform2D,
-                 VaryingCelestialTransform3D)
-        ):
+        if not obj._is_inverse:
             return "asdf://dkist.nso.edu/tags/varying_celestial_transform-1.1.0"
-        elif isinstance(
-                obj,
-                (InverseVaryingCelestialTransform,
-                 InverseVaryingCelestialTransform2D,
-                 InverseVaryingCelestialTransform3D)
-        ):
+        elif obj._is_inverse:
             return "asdf://dkist.nso.edu/tags/inverse_varying_celestial_transform-1.1.0"
         else:
             raise ValueError(f"Unsupported object: {obj}")  # pragma: no cover
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Refactor various subclasses of VaryingCelestialTransform to centralise the calculations in preparation for improving performance.