Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate changes to workshop materials from old repo #493

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SolarDrew
Copy link
Contributor

No description provided.

@SolarDrew SolarDrew added the Documentation docs docs docs label Jan 16, 2025
@@ -30,20 +30,63 @@ On Linux you can do this using the `-restrict-paths` command line argument, or b
On Windows and Mac OS this option is in the "Access" tab of the configuration options.
Globus will only be able to transfer files onto your machine in the specified paths.

### The Globus web app
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually want to include all this? Also you seem to be missing the images if we do.

```

would save the file to `~/dkist_data/BKPLX/VISP_2023_10_16T18_21_47_508_00630200_I_BKPLX_L1.fits`.
would save the file to `~/sunpy/data/BKPLX/VISP_2023_10_16T18_21_47_508_00630200_I_BKPLX_L1.fits`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the old path was correct?

aia.plot(axes=ax)
```

#### Computing the VISP field of View
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These examples probably suffer from the issue that they wont handle rotation properly. I think the best thing to do would be to either leave this for now or use sunpy.visualization.drawing.extent from 6.1.

## More advanced plotting
### Using AIA as a Context Image

#### Fetching an AIA Image
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

```

```{code-cell} ipython3
res = Fido.search(a.dkist.Dataset("BKPLX"))
asdf_file = Fido.fetch(res, path="~/dkist_data/{instrument}_{dataset_id}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path change is wrong, it means it's not the path the sample data is in.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file seems to be missing from the index.md file


```python
import dkist
from dkist.data.sample import VBI_AJQWW
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to be consistent on how we load data and sample data, but this probably isn't the PR to argue it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation docs docs docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants