Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow access of the filenames from the dataset object #56

Merged
merged 3 commits into from
May 16, 2019

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented May 16, 2019

No description provided.

@Cadair Cadair added this to the 17 milestone May 16, 2019
@Cadair Cadair force-pushed the filenames_from_dataset branch 2 times, most recently from 1229f44 to e1f3ca3 Compare May 16, 2019 13:42
@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #56 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   97.42%   97.45%   +0.02%     
==========================================
  Files          21       21              
  Lines        1050     1061      +11     
==========================================
+ Hits         1023     1034      +11     
  Misses         27       27
Impacted Files Coverage Δ
dkist/dataset/dataset.py 96.66% <100%> (+0.07%) ⬆️
dkist/io/fits.py 100% <100%> (ø) ⬆️
dkist/io/reference_collections.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a176de...5449696. Read the comment docs.

@Cadair Cadair merged commit 3964377 into DKISTDC:master May 16, 2019
@Cadair Cadair deleted the filenames_from_dataset branch May 16, 2019 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant