Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Dataset.download method #57

Merged
merged 7 commits into from
May 24, 2019
Merged

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented May 20, 2019

This was the easy bit. Now I have to actually make a test dataset that I can test it against (and write unit tests obv)

@Cadair Cadair added this to the 17 milestone May 24, 2019
@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

Merging #57 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #57      +/-   ##
=========================================
+ Coverage   97.45%   97.5%   +0.04%     
=========================================
  Files          21      21              
  Lines        1061    1082      +21     
=========================================
+ Hits         1034    1055      +21     
  Misses         27      27
Impacted Files Coverage Δ
dkist/asdf_maker/generator.py 100% <ø> (ø) ⬆️
dkist/utils/globus/endpoints.py 100% <ø> (ø) ⬆️
dkist/dataset/dataset.py 97.22% <100%> (+0.55%) ⬆️
dkist/utils/globus/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3964377...f07a57a. Read the comment docs.

@Cadair Cadair force-pushed the dataset_download branch from c9e8bdc to f342387 Compare May 24, 2019 09:42
@Cadair Cadair force-pushed the dataset_download branch from f342387 to 5d662e4 Compare May 24, 2019 09:44
@Cadair Cadair merged commit 24ff54b into DKISTDC:master May 24, 2019
@Cadair Cadair deleted the dataset_download branch May 24, 2019 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant