Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement generation of ASDF inventory from headers and WCS #76

Merged
merged 13 commits into from
Mar 27, 2020

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Mar 12, 2020

These changes are to facilitate the automatic generation of the asdf files inside the data centre.

TODO:

  • Update the asdf maker test datasets + all asdf files to use spec 214 / new asdf schema.
  • tests, oh so many tests.

@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #76 into master will increase coverage by 0.13%.
The diff coverage is 97.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage   94.07%   94.21%   +0.13%     
==========================================
  Files          29       28       -1     
  Lines        1265     1330      +65     
==========================================
+ Hits         1190     1253      +63     
- Misses         75       77       +2     
Impacted Files Coverage Δ
dkist/dataset/dataset.py 95.69% <83.33%> (-0.94%) ⬇️
dkist/io/asdf/generator/transforms.py 97.19% <86.66%> (-1.04%) ⬇️
dkist/io/asdf/generator/generator.py 96.49% <100.00%> (+1.66%) ⬆️
dkist/io/asdf/generator/helpers.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8af842...1538bf4. Read the comment docs.

@Cadair Cadair changed the title WIP Implement ASDF maker service Implement generation of ASDF inventory from headers and WCS Mar 26, 2020
@Cadair Cadair merged commit 91f2c15 into DKISTDC:master Mar 27, 2020
@Cadair Cadair deleted the asdf_maker_service branch March 27, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant