Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dataset search for sunpy 2.1 #89

Merged
merged 7 commits into from
Feb 1, 2021

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Jan 27, 2021

This is work to update our search client for changes upcoming in 2.1. Currently waiting on sunpy/sunpy#4789

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #89 (67fc5ae) into master (0f03e5d) will increase coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   91.79%   92.01%   +0.22%     
==========================================
  Files          24       24              
  Lines         963      927      -36     
==========================================
- Hits          884      853      -31     
+ Misses         79       74       -5     
Impacted Files Coverage Δ
dkist/net/attrs.py 96.55% <ø> (-0.17%) ⬇️
dkist/net/attr_walker.py 98.87% <100.00%> (ø)
dkist/net/client.py 100.00% <100.00%> (+5.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f03e5d...67fc5ae. Read the comment docs.

@Cadair Cadair marked this pull request as draft January 27, 2021 15:24
@Cadair Cadair marked this pull request as ready for review February 1, 2021 12:24
@Cadair Cadair merged commit 3e349c3 into DKISTDC:master Feb 1, 2021
@Cadair Cadair deleted the fido_integration branch February 1, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant