-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve typing coverage #175
Conversation
Looked over the changes and they seem to check out, just a comment on if docstrings should be checked at the same time now that the same files being modified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If no other docstrings are about to be modified, LGTM!
At the end, it was not much so I did the changes. I also improved the error messages to address #180. |
* Improve typing coverage * Even more types * Fixes * Update changelog * Unified docstrings * Improve error messages for unsupported spaces
Description
Addresses part of #1
Done:
Missing:
Motivation and Context
closes #87
Types of changes
Checklist:
make format
(required)make check-codestyle
andmake lint
(required)make pytest
andmake type
both pass. (required)Note: we are using a maximum length of 127 characters per line
The remaining method without a return type are (2 because they are abstract method and one because pytype does not play nicely with it):