-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored ContinuousCritic for SAC/TD3 #78
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 tasks
Miffyli
reviewed
Jun 30, 2020
Miffyli
reviewed
Jun 30, 2020
Miffyli
reviewed
Jun 30, 2020
Miffyli
reviewed
Jun 30, 2020
Left couple of comments, just doc stuff. Other than that it looks good to me 👍 |
…-baselines3 into refactor/off-policy-critic
@Miffyli sorry, I did my edits last week but did not pushed them... |
Looks good to me :)
No biggie, happens to all of us :D |
Miffyli
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Preparing #3, it merges SAC and TD3 critics and it will be used by DDPG soon.
I added a parameter
n_critics
, even though SAC/TD3 only supportn_critics=2
for now. (It will be mainly useful for DDPG)Motivation and Context
Types of changes
Checklist:
make lint
make pytest
andmake type
both pass.