Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIGLViewer: Use GLOB_RECURSE in CMake for src files, no more need for manual addition of .h, .cpp or .ui files #1052

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

joergbrech
Copy link
Contributor

Description

The title sais it all.

How Has This Been Tested?

TiGLViewer still builds locally and in CI.

Screenshots, that help to understand the changes(if applicable):

Checklist:

Task Finished Reviewer Approved
At least one test for the new functionality was added.
  • yes
  • does not apply
  • OK
New classes have been added to the Python interface.
  • yes
  • does not apply
  • OK
The code is properly documented with doxygen docstrings
  • yes
  • does not apply
  • OK
Changes are documented at the top of ChangeLog.md
  • yes
  • does not apply
  • OK

@joergbrech joergbrech force-pushed the glob-recurse-tiglviewer-src-files branch from 1570d4b to 222bbee Compare January 22, 2025 23:23
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.50%. Comparing base (4b34202) to head (222bbee).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1052   +/-   ##
=======================================
  Coverage   69.50%   69.50%           
=======================================
  Files         301      301           
  Lines       26912    26912           
=======================================
  Hits        18705    18705           
  Misses       8207     8207           
Flag Coverage Δ
unittests 69.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@svengoldberg svengoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@svengoldberg svengoldberg merged commit 1f124c5 into master Jan 23, 2025
18 checks passed
@svengoldberg svengoldberg deleted the glob-recurse-tiglviewer-src-files branch January 23, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants