Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies upgrade. Unit tests refactor #209

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

axel-muller
Copy link
Collaborator

No description provided.

@axel-muller axel-muller marked this pull request as ready for review April 17, 2024 11:48
Copy link
Collaborator

@SurfingNerd SurfingNerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Jop upgrading the dependencies.
the bigint stuff makes code much better.
for the claiming contracts and the UI, we went to Node V18, instead of V20, because of some troubles with v20.
I am trying to get at least the active projects on the same tech stack.
We should either upgrade the other projects as well to v20,
or check if this works on v18 as well.
ATM V20 is edge new, but also the most active LTS.
Are there other good reasons for V20 ?

@axel-muller
Copy link
Collaborator Author

Good Jop upgrading the dependencies. the bigint stuff makes code much better. for the claiming contracts and the UI, we went to Node V18, instead of V20, because of some troubles with v20. I am trying to get at least the active projects on the same tech stack. We should either upgrade the other projects as well to v20, or check if this works on v18 as well. ATM V20 is edge new, but also the most active LTS. Are there other good reasons for V20 ?

Can confirm it works with latest lts v18 version too. Downgraded CI to node v.18.

@axel-muller axel-muller requested a review from SurfingNerd April 18, 2024 10:58
@SurfingNerd SurfingNerd merged commit ce19d5c into DMDcoin:master Apr 18, 2024
4 checks passed
@martyb166
Copy link

author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants