Skip to content

Commit

Permalink
IsuueID # remove period in front of classes in CHANGELOG.md as
Browse files Browse the repository at this point in the history
replacement of classes might cause user to classes in views.
  • Loading branch information
John Pinto committed Nov 15, 2023
1 parent 6dafe48 commit 95e2bd8
Showing 1 changed file with 26 additions and 26 deletions.
52 changes: 26 additions & 26 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ https://bibwild.wordpress.com/2019/06/10/what-happened-to-grid-float-breakpoint-
- Node package changes:
* Changed version of `bootstrap "^3.4.1"` --> `"^5.2.3"`
* Added `@popperjs/core.`
* Removed `bootstrap-3-typeahead, bootstrap-sass & popper.js`.
* Removed `bootstrap-3-typeahead, bootstrap-sass & popper.js`
- Stylesheet changes
* In `app/assets/stylesheets/application.scss`:
+ removed `bootstrap-sass` import <br>
Expand Down Expand Up @@ -52,41 +52,41 @@ https://bibwild.wordpress.com/2019/06/10/what-happened-to-grid-float-breakpoint-
`@include media-breakpoint-down(md) {}`
- Deleted `app/javascript/src/utils/popoverHelper.js`
- Using Bootstrap 5 accordion and spinner now. This replaces bespoke versions used.
+ The spinner block now uses class `.d-none` instead of `.hidden` to hide.
+ The spinner block now uses class `d-none` instead of `hidden` to hide.
- Bootstrap 5 dropped panels, thumbnails, wells and form-controls. So pages with them updated with Bootstrap 5 replacements.
+ All views with css classes `.panel, .panel-body, panel-*`. Have panel replaced
by card to give `.card, .card_body, .card-*`, etc. As `.panel-default` and some other
+ All views with css classes `panel, panel-body, panel-*` Have panel replaced
by card to give `card, .card_body, .card-*`, etc. As `panel-default` and some other
panel css classes don't have card equivalents with same suffixes we have
added these classes temporarily in _cards.sccs. For example,
`.card-default`, etc.
- Pages with css classes nav `.nav` and `.navbar` updated to work with Bootstrap 5:
`card-default`, etc.
- Pages with css classes nav `nav` and `navbar` updated to work with Bootstrap 5:
+ CSS classes changes:
- `.nav .navbar-nav` combination --> `.navbar-nav`
- `.navbar-toggle` --> `.navbar-toggler`
- multiple spans in `.navbar-toggle` button with class `.icon-bar`<br> --> single span with `.toggler-icon`
- Lists with `.nav .navbar-nav` have class `.nav-item` added to list elements.
- Dropdown list items with class `.dropdown` in navigation bar have class `.nav-item` and links in the lists have `.nav-link` added.
- `nav .navbar-nav` combination --> `navbar-nav`
- `navbar-toggle` --> `navbar-toggler`
- multiple spans in `navbar-toggle` button with class `icon-bar`<br> --> single span with `toggler-icon`
- Lists with `nav .navbar-nav` have class `nav-item` added to list elements.
- Dropdown list items with class `dropdown` in navigation bar have class `nav-item` and links in the lists have `nav-link` added.
+ SCSS files `app/assets/stylesheets/blocks/_navbars.scss` and `app/assets/stylesheets/blocks/_navs.scss` updated.
+ Data attributes changes required by Bootstrap 5 (as used by accordion and dropdown buttons):
- `data-display` --> `data-bs-display`
- `data-parent` -->`data-bs-parent`
- `data-target` -->`data-bs-target`
- `data-toggle` --> `data-bs-toggle`
+ Notifications now use classes `.d-block` and `.d-none` to show and hide respectively.
+ Bootstrap 5 Popover added to some dropdown-menu items by adding attribute `data-bs-toggle="popover"`.
+ Notifications now use classes `d-block` and `d-none` to show and hide respectively.
+ Bootstrap 5 Popover added to some dropdown-menu items by adding attribute `data-bs-toggle="popover"`
+ `float-start` and `float-end` replaced with `pull-left` and `pull-right` respectively
+ `form-group` class replaced with `form-control`
+ Input group addons are now specific to their placement relative to an input. So `.input-group-addon` and in our case we replaced with
`.input-group-addon`.
+ Renamed `.btn-default` to `.btn-secondary` and variable `$btn-default-color` changed to `$btn-secondary-color`.
+ Renamed `.img-responsive` to `.img-fluid`.
+ Renamed `.checkbox` and `.radio` into `.form-check`.
+ Class `.label` has been removed and replaced by `.badge` to disambiguate from the `<label>` element.
- Renamed `.label` class to `.badge`
- Replaced `.label-default` by `bg-secondary`
- Replaced `.label-info` by `bg-info`
- Replaced `.label-warning` by `bg-warning text-dark`
- Replaced `.label-danger` by `bg-danger`
+ Input group addons are now specific to their placement relative to an input. So `input-group-addon` and in our case we replaced with
`input-group-addon`
+ Renamed `btn-default` to `btn-secondary` and variable `$btn-default-color` changed to `$btn-secondary-color`
+ Renamed `img-responsive` to `img-fluid`
+ Renamed `checkbox` and `radio` into `form-check`
+ Class `label` has been removed and replaced by `badge` to disambiguate from the `<label>` element.
- Renamed `label` class to `badge`
- Replaced `label-default` by `bg-secondary`
- Replaced `label-info` by `bg-info`
- Replaced `label-warning` by `bg-warning .text-dark`
- Replaced `label-danger` by `bg-danger`


## V4.1.1
Expand Down Expand Up @@ -114,7 +114,7 @@ All gem and JS dependencies were also updated via `bundle update && yarn upgrade

- Upgrade to Ruby version 3.0.5 [#3225](https://github.com/DMPRoadmap/roadmap/issues/3225)
- Bumped all Github actions to use ruby 3.0
- Removed `.freeze` from Regex and Range constants since those types are already immutable
- Removed `freeze` from Regex and Range constants since those types are already immutable
- Fixed Rubocop complaint about redundancy of `r.nil? ? nil : r.user`, so changed it to `r&.user` in `app/models/plan.rb`
- Fixed Rubocop complaint about redundant `::` in config.log_formatter = `::Logger::Formatter.new` in `config/environments/production.rb`
- Froze `lib/deprecators/*.rb` constants that were Strings
Expand All @@ -141,7 +141,7 @@ As Webpacker is no longer maintained by the Rails community, we have replaced it
- Added `cssbundling-rails` gem and DartSass JS library
- Updated SASS stylesheets following the migration to the latest version of the `sass` package (See below).
- Removed `font-awesome-sass` gem and used `@fortawesome/fontawesome-free` npm package
- Issue with `@import 'font-awesome-sprockets';` line in `app/assets/stylesheets/application.scss`. Removed that line after referring to the latest font-awesome install/setup guide which no longer includes it.
- Issue with `@import 'font-awesome-sprockets';` line in `app/assets/stylesheets/application.scss` Removed that line after referring to the latest font-awesome install/setup guide which no longer includes it.

With the removal of Webpacker, the Javascript/SASS code is no longer automaticaly compiled when using the `rails server` command. It has been replaced by the `bin/dev` command that launch the rails server and the processes that watch for changes in the SASS and Javascript code.

Expand Down

0 comments on commit 95e2bd8

Please sign in to comment.