Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The V1 API Docs link in Edit profile > API access tab was broken. #3470

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

The V1 API Docs link in Edit profile > API access tab was broken. #3470

wants to merge 1 commit into from
+2 −1

Conversation

johnpinto1
Copy link
Contributor

Updated URL in config.x.application.api_documentation_urls property in config/initializers/_dmproadmap.rb.
Selection_029

@johnpinto1 johnpinto1 force-pushed the fix-for-broken-v1-api-doc-link branch from 40be787 to 4fe0792 Compare December 16, 2024 14:11
@johnpinto1 johnpinto1 changed the title The V1 API link in Edit profile > API access tab was broken. The V1 API Docs link in Edit profile > API access tab was broken. Dec 16, 2024
@johnpinto1 johnpinto1 self-assigned this Dec 16, 2024
The V1 API docs link in Edit profile > API access tab was broken.
90a4809 
Updated URL in config.x.application.api_documentation_urls property in
config/initializers/_dmproadmap.rb.
@johnpinto1 johnpinto1 force-pushed the fix-for-broken-v1-api-doc-link branch from d72cd71 to 90a4809 Compare December 16, 2024 16:48
@johnpinto1
Copy link
Contributor Author

johnpinto1 commented Dec 16, 2024 •
edited
Loading

BTW the link property is also used in the app/mailers/user_mailer.rb.

roadmap/app/mailers/user_mailer.rb

Lines 208 to 210 in 2d707d5

@api_docs = Rails.configuration.x.application.api_documentation_urls[:v1]
@name = @api_client.contact_name.present? ? @api_client.contact_name : @api_client.contact_email

aaronskiba
aaronskiba approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@aaronskiba aaronskiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronskiba aaronskiba aaronskiba approved these changes

@benjaminfaure benjaminfaure Awaiting requested review from benjaminfaure

Assignees

@johnpinto1 johnpinto1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnpinto1 @aaronskiba