Add slot_id check

Signed-off-by: Wenxing Hou <[email protected]>
DMTF · Jun 30, 2022 · 97d23cb · 97d23cb
1 parent f73d435
commit 97d23cb
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/library/spdm_responder_lib/libspdm_rsp_certificate.c b/library/spdm_responder_lib/libspdm_rsp_certificate.c
@@ -107,7 +107,7 @@ libspdm_return_t libspdm_get_response_certificate(void *context,
     if (spdm_context->local_context
         .local_cert_chain_provision[slot_id] == NULL) {
         return libspdm_generate_error_response(
-            spdm_context, SPDM_ERROR_CODE_UNSPECIFIED,
+            spdm_context, SPDM_ERROR_CODE_INVALID_REQUEST,
             0, response_size, response);
     }
 

diff --git a/library/spdm_responder_lib/libspdm_rsp_challenge_auth.c b/library/spdm_responder_lib/libspdm_rsp_challenge_auth.c
@@ -99,6 +99,15 @@ libspdm_return_t libspdm_get_response_challenge_auth(void *context,
                                                response_size, response);
     }
 
+    if (slot_id != 0xFF) {
+        if (spdm_context->local_context
+            .local_cert_chain_provision[slot_id] == NULL) {
+            return libspdm_generate_error_response(
+                spdm_context, SPDM_ERROR_CODE_INVALID_REQUEST,
+                0, response_size, response);
+        }
+    }
+
     signature_size = libspdm_get_asym_signature_size(
         spdm_context->connection_info.algorithm.base_asym_algo);
     hash_size = libspdm_get_hash_size(

diff --git a/library/spdm_responder_lib/libspdm_rsp_key_exchange.c b/library/spdm_responder_lib/libspdm_rsp_key_exchange.c
@@ -107,6 +107,15 @@ libspdm_return_t libspdm_get_response_key_exchange(void *context,
                                                response_size, response);
     }
 
+    if (slot_id != 0xFF) {
+        if (spdm_context->local_context
+            .local_cert_chain_provision[slot_id] == NULL) {
+            return libspdm_generate_error_response(
+                spdm_context, SPDM_ERROR_CODE_INVALID_REQUEST,
+                0, response_size, response);
+        }
+    }
+
     if (slot_id == 0xFF) {
         slot_id = spdm_context->local_context.provisioned_slot_id;
     }