The OpaqueData offset in libspdm_req_get_csr.c and libspdm_rsp_csr.c not match with the Byte offset of OpaqueData Field in GET_CSR request message format

[Zhiqiang520]

The OpaqueData offset in libspdm_req_get_csr.c and libspdm_rsp_csr.c does not match with the Byte offset of OpaqueData Field in Table 79 — GET_CSR request message format in DSP0274_1.2.1.pdf.

1. The OpaqueData offset in libspdm_req_get_csr.c should be 8 + RequesterInfoLength, following the spec.
   GET_CSR request message format
   

2. But now the OpaqueData offset in libspdm_req_get_csr.c is spdm_request + 1(=8) at the following line 97, it is actually RequesterInfo Field, not OpaqueData Field.
   

   libspdm/library/spdm_requester_lib/libspdm_req_get_csr.c

   Lines 96 to 106 in e545b07

   	if (opaque_data_length != 0) {
   	libspdm_copy_mem(spdm_request + 1,
   	spdm_request_size - sizeof(spdm_get_csr_request_t),
   	(uint8_t *)opaque_data, opaque_data_length);
   	}
   	if (requester_info_length != 0) {
   	libspdm_copy_mem((uint8_t *)(spdm_request + 1) + opaque_data_length,
   	spdm_request_size - sizeof(spdm_get_csr_request_t),
   	(uint8_t *)requester_info, requester_info_length);
   	}

3. The same issue is also in libspdm_rsp_csr.c at the following line 116.
   

   libspdm/library/spdm_responder_lib/libspdm_rsp_csr.c

   Line 116 in e545b07

   opaque_data = (void*)((size_t)(spdm_request + 1));

[steven-bellock]

Looks like that's been there since the very beginning : 0ab2787 Nobody has complained probably because

1. Nobody has a use for those fields.
2. Nobody is using GET_CSR.

But this highlights a deficiency in the unit tests, as they aren't checking the values of those fields.

[jyao1]

I think probably we also need to fix in 2.3 branch.

Also need to check unit test.

[Xiaohanjlll]

I can take this issue

[steven-bellock]

I think probably we also need to fix in 2.3 branch.

Also need to check unit test.

We can bundle it with the other fix.