Initial draft for message logging #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is to solicit feedback on the API (spdm_requester_lib.h) and backend design. Currently only supports * GET_MEASUREMENTS / MEASUREMENTS * Non-wrapping writes that don't clamp. I am not sure how this will be tested. Signed-off-by: Steven Bellock <[email protected]>
|
@PrithviAPai @vbodired Please review the API in |
taprinz
reviewed
Aug 25, 2022
My recommendation is to add unit_test. Just use get_measurement. |
jyao1
reviewed
Aug 26, 2022
jyao1
reviewed
Aug 26, 2022
jyao1
reviewed
Aug 26, 2022
* Change msg_log.buffer_size to msg_log.max_buffer_size. * Change msg_log.offset to msg_log.buffer_size. * Implement new function libspdm_append_msg_log Signed-off-by: Steven Bellock <[email protected]>
steven-bellock
commented
Aug 26, 2022
Signed-off-by: Steven Bellock <[email protected]>
|
Need to add |
And add message logging to VCA to support 1.2 measurement log. Signed-off-by: Steven Bellock <[email protected]>
Signed-off-by: Steven Bellock <[email protected]>
steven-bellock
commented
Aug 31, 2022
And disable message logging at end of test case. Signed-off-by: Steven Bellock <[email protected]>
And change LIBSPDM_MSG_LOG_STATUS_CLAMP to LIBSPDM_MSG_LOG_STATUS_BUFFER_FULL. Signed-off-by: Steven Bellock <[email protected]>
Signed-off-by: Steven Bellock <[email protected]>
|
@jyao1 @taprinz I've marked this ready for review. I decided to leave off the wrapping behavior until someone requests it, so right now when the buffer is full then it will stop writing to it. It currently only logs |
steven-bellock
commented
Aug 31, 2022
Signed-off-by: Steven Bellock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is to solicit feedback on the API (spdm_requester_lib.h) and backend design. Currently only supports
I am not sure how this will be tested.
Signed-off-by: Steven Bellock [email protected]