Change session_id generate #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyao1
reviewed
Dec 13, 2022
spdm_dump/spdm/spdm_dump_spdm.c
Outdated
| @@ -1966,7 +1966,7 @@ void dump_spdm_key_exchange_rsp(const void *buffer, size_t buffer_size) | |||
| } | |||
|
|
|||
| m_cached_session_id = | |||
| m_cached_session_id | spdm_response->rsp_session_id; | |||
| m_cached_session_id | (spdm_response->rsp_session_id << 16); | |||
There was a problem hiding this comment.
why not use libspdm_generate_session_id()?
Signed-off-by: Wenxing Hou <[email protected]>
Signed-off-by: Wenxing Hou <[email protected]>
Fix the issue: DMTF#63 Signed-off-by: Wenxing Hou <[email protected]>
Wenxing-hou
force-pushed
the
change_session_id_generate
branch
from
2cbb9eb to
037fec1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #63
Signed-off-by: Wenxing Hou [email protected]