Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change regarding the files storage location #58

Closed
stetard opened this issue Nov 7, 2023 · 1 comment · Fixed by #60
Closed

Breaking change regarding the files storage location #58

stetard opened this issue Nov 7, 2023 · 1 comment · Fixed by #60

Comments

@stetard
Copy link
Contributor

stetard commented Nov 7, 2023

Describe the bug

After upgrade the module from 3.5.6 to 4.1.1, customized file downloads are using to a bad location.

Software Versions

  • DNN: 09.13.00
  • Module: 04.01.01

To Reproduce

Steps to reproduce the behavior:

  1. Upgrade an old website using the 3.5.6 version to the 4.1.1
  2. Click on the download link for a file listed by an existing module (created with the old version)
  3. The error message is: [FileNotFoundException: Could not find file 'C:\Website\Portals\0\Repository...

Expected behavior

User should obtain the selected file when clicking on the download link.

Additional context

This problem occurs when the file storage location have been customized with an old Repository module version.
In this cas, the correct path is 'C:\Website\Portals\0\Download...' instead of the default ''C:\Website\Portals\0\Repository...'.

@stetard
Copy link
Contributor Author

stetard commented Nov 7, 2023

I'm wondering why the module settings doesn't allow anymore to use a specific folder to store the file.
Is this related to some security risks?

I think it could be better if the module accept some old customized locations and only block the personalisation for the new module instances.

stetard added a commit to stetard/DNN.Repository that referenced this issue Nov 8, 2023
… contains some customized storage locations
stetard added a commit to stetard/DNN.Repository that referenced this issue Nov 8, 2023
valadas added a commit that referenced this issue Dec 8, 2023
…ations

#58 Keep backward compatibility for upgraded modules that contains some customized storage locations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant