Fixed an issue where extra data was appended to end of downloaded file #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue DNNCommunity#55 for extra data appended to end of downloaded file
|
Nice contribution! A quick question, though... Shouldn't the |
|
@WillStrohl content-type is still there but it is using the property instead of the method. This looks good to me. Merging. |
valadas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #55 for extra data appended to end of downloaded file
This is the code I've always used for file downloads in ASP.Net. I'm unclear why the original code, which calls a native Response method, misbehaves. I do know this code hasn't failed me to date.
Although I suggest wrapping it in a try/catch, as if the user cancels the download dialog it throws an exception in the module.
Description of PR...
Changes made
PR Template Checklist
Please mark which issue is solved
Close #55