Pn development #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omization and configuration read/writes. Could be used to replace the programTime.txt text file that only stores a user defined ProgramTime.
…log to retrieve defined programtime from the cfg file.
…to cover users installing dependencies while within RECNET
…just software to start referring to this config file.
…ve forecast in a new file. Saving and opening files now writes an entry in the config file. On start-up, the config file entry is set to blank. If this entry is blank, the File>Save auto-save function defaults to the SaveAs behavior.
…ab. Need to modify POR entry in the data doctionary to accept a time range (2 ints) rather than just a single int.
…rates with software as is without data dictionary modifications.
…te new entries to the datasetDictionary to prevent duplicates.
… QComboBox. Users report that mouse-scroll is intercepted by the comboboxes when the cursor hovers over them. This commit prevents that.
kevinfol
reviewed
Jan 29, 2019
Resources/application.py
Outdated
|
|
||
| return | ||
|
|
||
| def readConfig(self, configKey, configGroup='DEFAULT'): |
There was a problem hiding this comment.
I'd just import this function from Resources/Functions/miscFunctions instead of re-writing the whole function here.
There was a problem hiding this comment.
yup. forgot that i pulled that out and put it into miscFunctions. next commit does what you suggest here.
kevinfol
reviewed
Jan 29, 2019
Resources/application.py
Outdated
| config.read('Resources/tempFiles/pyforecast.cfg') | ||
| return config[configGroup][configKey] | ||
|
|
||
| def writeConfig(self, configKey, configVal, configGroup='DEFAULT'): |
There was a problem hiding this comment.
Same as above. Just import from miscFunctions.
kevinfol
reviewed
Jan 29, 2019
kevinfol
reviewed
Jan 29, 2019
tjrocha
added a commit
that referenced
this pull request
Aug 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request pull for commits shown below. Main changes: