Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted change to camsolveAll test #3976

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Conversation

jessemapel
Copy link
Contributor

Description

This file was changed while I was debugging and slipped into the PR. The change doesn't impact the test, but it does spew an extra file out into the test directory. This just reverts the Makefile back to what it was.

Related Issue

Fix from #3947

Motivation and Context

Re-disabled outputing the bundle text file.

How Has This Been Tested?

Tested on Ubuntu and Mac 10.13

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the AUTHORS.rst document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@jessemapel jessemapel requested a review from krlberry August 19, 2020 20:11
Copy link
Contributor

@krlberry krlberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This makes sense.

@jessemapel
Copy link
Contributor Author

Gonna wait on CI to merge this.

@jessemapel jessemapel merged commit d293869 into DOI-USGS:dev Aug 20, 2020
@jessemapel
Copy link
Contributor Author

This will fix the camsolveall failures. It's failing because the jigsaw parameters changed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants