Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Unit Test for OSIRIS-REx SamCam #4378

Merged
merged 2 commits into from
Mar 30, 2021

Conversation

amystamile-usgs
Copy link
Contributor

Description

Updated existing SamCam unit test that was recently converted to a gtest. Updated SamCam gtest to reflect the PolyCam unit gtest.

I did not include the provided test image due to the fact that these gtests were working with a fixture and therefore avoiding having to introduce more test data.

I did not update the existing fixture functions due to not finding any camera specific changes needed for SamCam other than updating the instrument id.

Related Issue

#4280

Motivation and Context

Provides better testing coverage for OSIRIS-REx camera models.

How Has This Been Tested?

Tested with the updated SamCam gtest.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@amystamile-usgs amystamile-usgs linked an issue Mar 25, 2021 that may be closed by this pull request
@scsides scsides requested a review from jessemapel March 26, 2021 15:48
@Kelvinrr Kelvinrr merged commit 9820ba9 into DOI-USGS:dev Mar 30, 2021
@amystamile-usgs amystamile-usgs deleted the SamCamTests branch April 6, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit test for OSIRIS-REx SamCam
4 participants