Added Table logic to copy label comments #4496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessemapel
reviewed
May 27, 2021
|
Some tests are failing (segfault) on Jenkins, but they're passing locally. The tests passed on the first commit (with the actual changes to the table logic), but unrelated tests are now failing following the addition of a test. The test that I changed is not failing. |
jessemapel
approved these changes
May 28, 2021
This was referenced Jul 13, 2021
|
The CHANGELOG entry did not make it into this PR, I will follow up with a new PR to correct that. |
13 tasks
jessemapel
pushed a commit
that referenced
this pull request
Jul 28, 2021
* Added logic to copy label comments * Added comment logic to ToFromBlob test Co-authored-by: Austin Sanders <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functionality to copy label comments in Table::toBlob()
Description
Adds functionality to copy label comments in Table::toBlob()
Locally failing on cubediff_app_test_withTable, but I'm not sure why. Running diff on the truth/output .txt files results in no differences.
Related Issue
Closes #4442
Motivation and Context
Bug fix. Comments were dropped from tables as a result of the BLOB refactor.
How Has This Been Tested?
Ran jigsaw and verified that the output included comments (see screenshot)
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: