Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update calls to GetFileName with get GetCubeName #4779

Merged
merged 4 commits into from
Feb 28, 2022
Merged

Conversation

scsides
Copy link
Contributor

@scsides scsides commented Feb 7, 2022

Change calls of GetFileName(some_cube_name) to GetCubeName

Description

These changes will allow Input cubes to automatically process the cube attributes (i.e., band numbers). New apps should always use GetCubeName when the apps XML file uses TYPE set to CUBE

Related Issue

Motivation and Context

Apps converted to callable routines often don't process input cube attributes, and when they do the code is repeated exactly for every callable conversion.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@scsides scsides marked this pull request as draft February 7, 2022 16:23
@scsides scsides marked this pull request as ready for review February 25, 2022 14:44
Copy link
Contributor

@AustinSanders AustinSanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Since we aren't removing all instances of GetFileName throughout the codebase I had some trouble verifying that this replaces all necessary instances, but I think this is good to merge.

@scsides scsides merged commit be1fb81 into DOI-USGS:dev Feb 28, 2022
@scsides scsides deleted the att2 branch February 28, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants