fixed error where footprint fails to generate on some map projected images. fixes #4390 #4908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kelvinrr
commented
Apr 15, 2022
Comment on lines
+1333
to
+1337
| catch(std::exception &e) { | ||
| std::string msg = "Caught std::exception: "; | ||
| msg += e.what(); | ||
| throw IException(IException::Unknown, msg, _FILEINFO_); | ||
| } |
There was a problem hiding this comment.
std::exception wasn't being caught causing the real error of an incomplete linestring to be swllowed by catch(...)
Kelvinrr
commented
Apr 15, 2022
| @@ -852,7 +850,8 @@ namespace Isis { | |||
|
|
|||
| if (nPoleSample >= 0.5 && nPoleLine >= 0.5 && | |||
| nPoleSample <= p_cube->sampleCount() + 0.5 && | |||
| nPoleLine <= p_cube->lineCount() + 0.5) { | |||
| nPoleLine <= p_cube->lineCount() + 0.5 && | |||
| SetImage(nPoleSample, nPoleLine)) { | |||
There was a problem hiding this comment.
SetImage checks to see if the pixel can get a valid projection when going image->ground.
idk why ground->image successfully returns pixel coords but image->ground acknowledges that there is no intersection?
jlaura
approved these changes
Apr 15, 2022
|
gonna wait until test finishes |
|
This should be good, only tests failing are the ones that have been fixed |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug where footprints fail to generate when these specific conditions are met:
Which results in the image footprint becoming mangled.
Related Issue
#4390
Motivation and Context
Some map projected images were not generating valid footprints.
How Has This Been Tested?
Original image in the issue successfully generated it's footprint when it previous excepted with incomplete linear ring coordinates.
Screenshots (if appropriate):
using image:
/archive/projects/europa/GLL_FinProducts/*/33ESGLOCOL01_GalileoSSI_Equi.cubFootprint trying to cross the pole, had to use a web geojson app since I had incomplete coords I was just printing out:
After fix, viewed in qmos:
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: