Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin qwt to 6.2.0 or lower #5503

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Pin qwt to 6.2.0 or lower #5503

merged 1 commit into from
Jun 4, 2024

Conversation

chkim-usgs
Copy link
Contributor

Description

qwt's latest version was bumped to 6.3.0 which causes an ISIS build error. Pinning qwt to <6.3.0 and creating a conda env with this change resulted in a successful ISIS dev build.

Also found that pinning qwt==6.2.0 caused a segfault during the ISIS build but <6.3.0 did not cause any errors.

Related Issue

Addresses #5498

How Has This Been Validated?

Created fresh conda environment with qwt <6.3.0 and built ISIS dev.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added myself to the .zenodo.json document.
  • I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

Copy link
Collaborator

@acpaquette acpaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great! Could this make its way into the meta.yml?

@chkim-usgs
Copy link
Contributor Author

@acpaquette Yes, qwt should already be pinned in the meta.yml?

@acpaquette
Copy link
Collaborator

@chkim-usgs Looks like it has pin_compatibility in the run section but we should pin the version in the build section

@chkim-usgs
Copy link
Contributor Author

@acpaquette qwt is pinned as <6.3.0 in the build section, should it be something else?

@acpaquette
Copy link
Collaborator

@chkim-usgs My bad, poor reading comp on my end. Looks good!

@chkim-usgs chkim-usgs merged commit 4b4c8f0 into DOI-USGS:dev Jun 4, 2024
chkim-usgs added a commit that referenced this pull request Jun 21, 2024
@chkim-usgs chkim-usgs mentioned this pull request Jun 21, 2024
12 tasks
chkim-usgs added a commit that referenced this pull request Jun 21, 2024
* Added kalasiris to dev meta.yml (#5487)

* Add qview stretch bugfix (#5492)

* Add qview stretch bugfix

* Update changelog

* Fix Failing HiJitter Tests (#5507)

* Fixes proj segfault if a match cube is provided

* Revert mcube back into a pointer and correctly handle it

* Qview command line Fix (#5505)

* Avoid double image load when opening cubes from cmdline in qview

* Added changelog entry

* Revert interval change

* Update docs

* Fix meta.yaml formatting

* Pin qwt to 6.2.0 or lower (#5503)

---------

Co-authored-by: acpaquette <[email protected]>
chkim-usgs added a commit that referenced this pull request Jun 24, 2024
* Added kalasiris to dev meta.yml (#5487)

* Add qview stretch bugfix (#5492)

* Add qview stretch bugfix

* Update changelog

* Fix Failing HiJitter Tests (#5507)

* Fixes proj segfault if a match cube is provided

* Revert mcube back into a pointer and correctly handle it

* Qview command line Fix (#5505)

* Avoid double image load when opening cubes from cmdline in qview

* Added changelog entry

* Revert interval change

* Update docs

* Fix meta.yaml formatting

* Pin qwt to 6.2.0 or lower (#5503)

* Pinned suitesparse to below 7.7.0 (#5528)

* Update code.json date

---------

Co-authored-by: acpaquette <[email protected]>
chkim-usgs added a commit to chkim-usgs/ISIS3 that referenced this pull request Nov 26, 2024
chkim-usgs added a commit to chkim-usgs/ISIS3 that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants