Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate docstrings and refactor abstract test classes to use class variables #273

Merged
merged 8 commits into from
May 29, 2020

Conversation

Roel
Copy link
Member

@Roel Roel commented May 28, 2020

  • I have read and followed the guidelines in the CONTRIBUTING document
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This PR removes docstrings from subclasses when they are identical to the ones provided in the upper class.

It also refactors the abstract test classes to use class variables instead of getter functions.

Should fix #262

@Roel Roel added this to the v2.0.0 milestone May 28, 2020
@Roel Roel merged commit 142ed67 into DOV-Vlaanderen:master May 29, 2020
@Roel Roel deleted the remove-duplicate-docstrings branch May 29, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove identical docstrings in subclasses
1 participant