Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused path. Add path for v2 #282

Merged
merged 2 commits into from
Nov 19, 2020
Merged

Conversation

martinalig
Copy link
Contributor

  • Cleanup unused paths
  • Add path for v2: due to the design of the current architecture, jwt tokens are strictly needed and there was no impact on leaving this path out. Suppling no jwt to the request ended in an validation error in the controller. adding a jwt token via authorzation header automatically invoked the authorization chain and required the jwt tokens to be properly signed.

@martinalig martinalig requested a review from ubamrein November 18, 2020 14:04
@martinalig martinalig requested a review from ubamrein November 18, 2020 16:20
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@martinalig martinalig merged commit 4e8b068 into develop Nov 19, 2020
@martinalig martinalig deleted the fix/security-config-for-v2 branch November 19, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants